Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,crypto: add extends for derived classes #29302

Merged
merged 1 commit into from
Aug 29, 2019
Merged

doc,crypto: add extends for derived classes #29302

merged 1 commit into from
Aug 29, 2019

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 25, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 25, 2019
@trivikr
Copy link
Member Author

trivikr commented Aug 26, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3856/

@trivikr trivikr self-assigned this Aug 26, 2019
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 26, 2019
lpinca
lpinca approved these changes Aug 26, 2019
View reviewed changes
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
@trivikr trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 26, 2019
@trivikr
Copy link
Member Author

trivikr commented Aug 26, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3858/

@trivikr
Copy link
Member Author

trivikr commented Aug 27, 2019

Ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3859/

@trivikr trivikr mentioned this pull request Aug 27, 2019
Merged
7 tasks
@trivikr
Copy link
Member Author

trivikr commented Aug 28, 2019

@nodejs/crypto

@Trott
Copy link
Member

Trott commented Aug 29, 2019

@trivikr Any reason to hold off on landing this?

@trivikr
Copy link
Member Author

trivikr commented Aug 29, 2019

Yet to get approvals after latest commit ce60c8ca703c654d2953330291f8c58bab0cdbea
Ping @jasnell @lpinca

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2019
@trivikr
doc,crypto: add extends for derived classes
c746ba4 
PR-URL: nodejs#29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@trivikr trivikr force-pushed the doc-crypto-extends branch from ce60c8c to c746ba4 Compare August 29, 2019 22:20
@trivikr
Copy link
Member Author

trivikr commented Aug 29, 2019

Landed in c746ba4

@trivikr trivikr merged commit c746ba4 into nodejs:master Aug 29, 2019
@trivikr trivikr deleted the doc-crypto-extends branch August 29, 2019 22:23
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@trivikr @BridgeAR
doc,crypto: add extends for derived classes
8c776cb 
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@trivikr @BridgeAR
doc,crypto: add extends for derived classes
ae810cc 
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@trivikr trivikr

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trivikr @Trott @jasnell @lpinca @nodejs-github-bot